[FFmpeg-soc] [soc]: r4919 - amr/amrnbdec.c

Robert Swain robert.swain at gmail.com
Tue Aug 4 10:45:13 CEST 2009


Hey,

2009/8/4 Diego Biurrun <diego at biurrun.de>:
> On Mon, Aug 03, 2009 at 07:03:43PM -0400, Ronald S. Bultje wrote:
>>
>> On Mon, Aug 3, 2009 at 7:00 PM, Diego Biurrun<diego at biurrun.de> wrote:
>> > On Mon, Aug 03, 2009 at 07:37:42PM +0200, cmcq wrote:
>> >> Use "if { y } else z" style
>> >
>> > Please do not use idiosyncratic styles, stick to K&R.
>>
>> If you have:
>>
>> if (x)
>>     a
>> else
>>     b
>>
>> Michael will ask to add {} atop (but not at the bottom), so:
>>
>> if (x) {
>>     a
>> } else
>>     b
>
> I only remember him asking for
>
>  if (x) {
>      a
>  } else {
>      b
>  }

I remember Michael asking for removal of {} but only if it saves a
line and so I told Colin to do this rather than if else with no {}.

Regards,
Rob


More information about the FFmpeg-soc mailing list