[FFmpeg-soc] [soc]: r4821 - in amr: amrnbfloatdata.h amrnbfloatdec.c

Diego Biurrun diego at biurrun.de
Wed Jul 29 01:42:20 CEST 2009


On Wed, Jul 29, 2009 at 12:14:22AM +0100, Colin McQuillan wrote:
> 2009/7/28 Diego Biurrun <diego at biurrun.de>:
> > On Tue, Jul 28, 2009 at 06:17:23PM +0200, cmcq wrote:
> >>
> >> Log:
> >> Don't include headers already included by libavutil/common.h
> >
> > Why?  I don't think this is a good idea.
> 
> I'm making sure each #include is justified - some of them were for
> functions that aren't used anymore. I'll have another go, trying not
> to rely on standard headers included by other headers.

Removing unused headers is OK, but headers required for things that are
used should be #included directly IMO.


More information about the FFmpeg-soc mailing list