[FFmpeg-soc] [soc]: r4321 - in concat/libavformat: . m3u.c playlist.c playlist.h

Ronald S. Bultje rsbultje at gmail.com
Mon Jun 1 23:23:27 CEST 2009


Hi,

On Mon, Jun 1, 2009 at 5:15 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, May 30, 2009 at 02:20:08AM +0200, gkovacs wrote:
>> +    put_tag(pb, ".snd");       /* magic number */
>> +    put_be32(pb, 24);           /* header size */
>> +    put_be32(pb, M3U_UNKNOWN_SIZE); /* data size */
>> +    put_be32(pb, (uint32_t)enc->codec_tag);     /* codec ID */
>> +    put_be32(pb, enc->sample_rate);
>> +    put_be32(pb, (uint32_t)enc->channels);
>
> A lot of this could be aligned for better readability.

Also, the casts seem pointless, since put_be32() knows that it deals
with an uint32_t (or, in fact, an unsigned int).

Ronald


More information about the FFmpeg-soc mailing list