[FFmpeg-soc] AACEnc #if 0 block

Alex Converse alex.converse at gmail.com
Thu Jun 18 05:22:33 CEST 2009


On Wed, Jun 17, 2009 at 11:16 PM, Kostya<kostya.shishkov at gmail.com> wrote:
> On Wed, Jun 17, 2009 at 03:28:42PM -0400, Alex Converse wrote:
>> On Wed, Jun 17, 2009 at 1:21 AM, Kostya<kostya.shishkov at gmail.com> wrote:
>> > On Tue, Jun 16, 2009 at 08:55:25PM -0400, Alex Converse wrote:
>> >> In aaccoder.c there is a large block of code like this:
>> >> #if 1
>> >> lots of code;
>> >> #else
>> >> similar code;
>> >> #endif
>> >>
>> >> What is the purpose of all that else code. Are we trying to move to it? Did
>> >> we move away from it and leave it behind? It makes navigating the file much
>> >> more painful because it share several function names with the code that is
>> >> turned on.
>> >
>> > IIRC it was in aaccoder.c for functions performing really full search
>> > which is times slower. I think you can merge differing bits under
>> > #ifdef USE_REALLY_FULL_SEARCH
>> > or something inside function body.
>> >
>>
>> Thanks for the explanation. How's this?
>>
>> --Alex
>
> looks ok
>

Applied


More information about the FFmpeg-soc mailing list