[FFmpeg-soc] [soc]: r4307 - in als: README alsdec.c

Diego Biurrun diego at biurrun.de
Sun May 24 21:55:33 CEST 2009


On Sun, May 24, 2009 at 09:38:10PM +0200, Thilo Borgmann wrote:
> > duE
> > ...
> > But this is a bad commit message.  It conveys no useful information.
> > ... 
> > You mix multiple different into one commit.  Bad.
> > ...
> > Indentation should be fixed.
> > ...
> > Dropping the als function prefix requires changes to the AVCodec
> > declaration.
> 
> So few changes and so much wrong.... seems like I have to get back into
> the standards.

You're learning the ropes, don't worry.  I just hope the other SoC
student's were listening and don't repeat your mistakes.

> I hope I've done better now.

You have.  Now please fix the commit message so that it provides useful
information and describes the changes you actually did.

Diego


More information about the FFmpeg-soc mailing list