[FFmpeg-soc] [PATCH] RTCP BYE

Josh Allmann joshua.allmann at gmail.com
Sun Aug 15 10:58:29 CEST 2010


Hi,

Here is a first attempt at RTCP BYE support, in bite-size patches.

0001 - Replace hardcoded RTCP packet types with an enum.

0002 - Reinstate rtp_get_file_handles function that is slated for
removal at the next major bump. We need to be able to get the RTCP fd
from the rtpproto.

0003 - Read RTCP packets from the RTSP demuxer. This might not be
strictly necessary, but it guarantees we'll read a RTCP packet if one
is available (without the availability of a RTP data packet).

0004 - According to RFC 3550, RTCP is always sent in
compound/aggregate form, starting with either a SR or RR packet, with
the other types (eg, BYE) following. This patch enables reading past
the first SR packet.

0005 - Actual BYE support. This is really kinda incomplete. It only
returns EOF, whereas we should be selectively removing the stream
(theoretically we could have concurrent streams playing, and one BYEs
while the others keep going). In the case where we get a BYE with only
one stream left, perhaps an EOF would be appropriate then.

Right now, not much happens since the EOF is propagated back to the
application layer. FFplay pretty much ignores it, although I suppose
it could (should?) be patched to call av_close_input_stream, so it
sends a proper TEARDOWN.

Josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-hard-coded-RTCP-packet-types-with-defines.patch
Type: text/x-patch
Size: 4357 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100815/0d9daa4b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Reinstate-rtp_get_file_handles-function-we-need-this.patch
Type: text/x-patch
Size: 1507 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100815/0d9daa4b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Read-RTCP-packets-in-RTSP-demuxer.patch
Type: text/x-patch
Size: 2250 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100815/0d9daa4b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Read-RTCP-compound-packets.patch
Type: text/x-patch
Size: 1611 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100815/0d9daa4b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-in-RTCP-BYE-support.patch
Type: text/x-patch
Size: 1605 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100815/0d9daa4b/attachment-0004.bin>


More information about the FFmpeg-soc mailing list