[FFmpeg-soc] [PATCH] RTCP BYE

[Ronald S. Bultje]

Hi,

On Wed, Aug 25, 2010 at 5:54 AM, Martin Storsjö <martin at martin.st> wrote:
> #2 looks ok, ok to commit, Luca/Ronald?

OK.

> #3 looks ok, ok to commit, Luca/Ronald?

Doesn't that include the RTCP filehandle for RDT-over-UDP as well? It shouldn't.

> #4 looks ok, I think, but could you redo it without reindenting the
> unmodified lines, to make it clearer?

I'm actually wondering if we shouldn't make RTCP packet parsing a
separate public function called from rtsp.c. That way, rtsp.c knows
better whether we're dealing with RTCP or RTP data.
rtsp_fetch_packet() makes some pretty bad assumptions based on that
now, all of that might be clean-uppable if we fix this by telling the
caller which FD the packet came from.

Ronald