[FFmpeg-soc] [PATCH] decouple mpeg4/aac from rtsp

Josh Allmann joshua.allmann at gmail.com
Thu Jun 24 10:31:06 CEST 2010


On 24 June 2010 00:14, Martin Storsjö <martin at martin.st> wrote:
> On Wed, 23 Jun 2010, Josh Allmann wrote:
>
>> Awesome -- patch 002 in this series also replaces memchr with strspn,
>> as noted by Michael and Ronald.
>
> This looks good to me (using #1 and #2 from the later mail). When moving
> sdp_parse_fmtp_config from rtsp.c to to be called parse_sdp_line in
> rtpdec_mpeg4, you could reindent the second parameter line right there
> instead of doing it in patch #7.
>

Fixed.

> Except that, this looks good to me. Ronald, Luca, any other opinions, or
> is this good to go?
>

Sweeet. Updated patchset is properly numbered.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-skip_spaces-in-favor-of-strspn.patch
Type: text/x-patch
Size: 4901 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/3f6b5d2e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Decouple-MPEG-4-and-AAC-specific-parts-from-rtsp.c.patch
Type: text/x-patch
Size: 10628 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/3f6b5d2e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Moved-more-SDP-FMTP-stuff-from-rtsp.c-to-mpeg4.c.patch
Type: text/x-patch
Size: 7247 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/3f6b5d2e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Move-AAC-depacketization-code-in-rtpdec-to-a-proper-.patch
Type: text/x-patch
Size: 7806 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/3f6b5d2e/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Move-RTPPayloadData-into-rtpdec_mpeg4-and-remove-all.patch
Type: text/x-patch
Size: 10729 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/3f6b5d2e/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Rename-PayloadContext-to-be-consistently-data.patch
Type: text/x-patch
Size: 5503 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/3f6b5d2e/attachment-0005.bin>


More information about the FFmpeg-soc mailing list