[FFmpeg-soc] [PATCH] decouple mpeg4/aac from rtsp

Luca Barbato lu_zero at gentoo.org
Thu Jun 24 13:27:50 CEST 2010


On 06/24/2010 09:14 AM, Martin Storsjö wrote:
> On Wed, 23 Jun 2010, Josh Allmann wrote:
> 
>> Awesome -- patch 002 in this series also replaces memchr with strspn,
>> as noted by Michael and Ronald.
> 
> This looks good to me (using #1 and #2 from the later mail). When moving 
> sdp_parse_fmtp_config from rtsp.c to to be called parse_sdp_line in 
> rtpdec_mpeg4, you could reindent the second parameter line right there 
> instead of doing it in patch #7.
> 
> Except that, this looks good to me. Ronald, Luca, any other opinions, or 
> is this good to go?

Seems so, I had just a look over them, if there isn't rush I'll try them
in the evening.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero



More information about the FFmpeg-soc mailing list