[FFmpeg-soc] [PATCH] decouple mpeg4/aac from rtsp

Josh Allmann joshua.allmann at gmail.com
Thu Jun 24 23:33:31 CEST 2010


On 24 June 2010 14:01, Josh Allmann <joshua.allmann at gmail.com> wrote:
> On 24 June 2010 13:46, Josh Allmann <joshua.allmann at gmail.com> wrote:
>> On 24 June 2010 12:53, Luca Barbato <lu_zero at gentoo.org> wrote:
>>> On 06/24/2010 10:31 AM, Josh Allmann wrote:
>>>> On 24 June 2010 00:14, Martin Storsjö <martin at martin.st> wrote:
>>>>>
>>>>> Except that, this looks good to me. Ronald, Luca, any other opinions, or
>>>>> is this good to go?
>>>>>
>>>>
>>>> Sweeet. Updated patchset is properly numbered.
>>>>
>>>
>>> Two nits
>>>
>>> 0002
>>>
>>> + * MPEG-4 Video RTP callbacks.
>>>
>>> Might be nice adding the rfc number there as well
>>>
>>
>> Added reference to RFC 3016.
>>
>>> 0004
>>>
>>> +#include <strings.h>
>>>
>>> string_s_ ?
>>>
>>
>> Needed for strcasecmp, apparently. Also fixed a related issue;
>> strings.h is now included in patch 003 rather than 004.
>>
>
> The minor indentation change Martin asked for in 002 somehow
> disappeared; patch re-done with this.

Re-attaching the whole series. Tested and works OK. Thumbs up??
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-skip_spaces-in-favor-of-strspn.patch
Type: text/x-patch
Size: 4901 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/9a0d6f69/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Decouple-MPEG-4-and-AAC-specific-parts-from-rtsp.c.patch
Type: text/x-patch
Size: 10639 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/9a0d6f69/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Moved-more-SDP-FMTP-stuff-from-rtsp.c-to-mpeg4.c.patch
Type: text/x-patch
Size: 7248 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/9a0d6f69/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Move-AAC-depacketization-code-in-rtpdec-to-a-proper-.patch
Type: text/x-patch
Size: 7785 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/9a0d6f69/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Move-RTPPayloadData-into-rtpdec_mpeg4-and-remove-all.patch
Type: text/x-patch
Size: 10729 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/9a0d6f69/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Rename-PayloadContext-to-be-consistently-data.patch
Type: text/x-patch
Size: 5503 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/9a0d6f69/attachment-0005.bin>


More information about the FFmpeg-soc mailing list