[FFmpeg-trac] #144(undetermined:open): ffmpeg 0.7c FFPLAY using CODEC_ID_H264 HUGE MEMORY LEAKS (1MB/s)

[FFmpeg]

#144: ffmpeg 0.7c FFPLAY using CODEC_ID_H264  HUGE MEMORY LEAKS (1MB/s)
------------------------------+---------------------------
Reporter:  alexandru_mg3      |       Owner:
    Type:  defect             |      Status:  open
Priority:  normal             |   Component:  undetermined
 Version:  0.7-rc1            |  Resolution:
Keywords:  h264 memory leaks  |  Blocked By:
Blocking:                     |  Reproduced:  0
Analyzed:  0                  |
------------------------------+---------------------------

Comment (by alexandru_mg3):

 Replying to [comment:1 cehoyos]:
 > Since I cannot reproduce your problem with a random H264/AC3/MPEG-TS
 file:
 >

 I found the BUG in ffplay:

 current video_thread function:
 ======================= CURRENT ffplay code
 =====================================

         ret = get_video_frame(is, frame, &pts_int, &pkt);
         pos = pkt.pos;
 #endif

         if (ret < 0) goto the_end;

         if (!ret)
             continue;

         pts = pts_int*av_q2d(is->video_st->time_base);

         ret = output_picture(is, frame, pts, pos);
 #if !CONFIG_AVFILTER
         av_free_packet(&pkt);
 ====================================================================

 new video_thread function:
 ======================= CORRECTED ffplay code
 =====================================

         ret = get_video_frame(is, frame, &pts_int, &pkt);
         pos = pkt.pos;

         // alexandru_mg3 - BEGIN - NEW CODE
         av_free_packet(&pkt);
         // alexandru_mg3 - END

 #endif

         if (ret < 0) goto the_end;

         if (!ret)
             continue;

         pts = pts_int*av_q2d(is->video_st->time_base);

         ret = output_picture(is, frame, pts, pos);
 #if !CONFIG_AVFILTER

         /* alexandru_mg3 - BEGIN - REMOVED CODE
          av_free_packet(&pkt);
         alexandru_mg3 - END
         */
 ....
 ====================================================================

 NOTE: NEED TO FREE THE PACKET EVEN FOR WHEN WE HAVE ERROR OR NEED TO
 IGNORE THEM

-- 
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/144#comment:2>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker