[FFmpeg-trac] #438(avformat:open): broken frame after seek in ogg container

FFmpeg trac at avcodec.org
Sat Feb 4 19:32:15 CET 2012


#438: broken frame after seek in ogg container
-------------------------------------+------------------------------------
             Reporter:  j            |                    Owner:
                 Type:  defect       |                   Status:  open
             Priority:  normal       |                Component:  avformat
              Version:  unspecified  |               Resolution:
             Keywords:  ogg theora   |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+------------------------------------

Comment (by reimar):

 I incorrectly mentioned this issue in commit d7b542ae, but that one only
 fixes issue #941.
 This issue can be fixed in a much more obvious way, but it risks breaking
 seeking completely for some files, and fixing it really correctly might be
 a bit tricky:
 --- a/libavformat/oggdec.c
 +++ b/libavformat/oggdec.c
 @@ -670,8 +670,8 @@ static int ogg_read_seek(AVFormatContext *s, int
 stream_inde

      ret = ff_seek_frame_binary(s, stream_index, timestamp, flags);
      os = ogg->streams + stream_index;
 -    if (ret < 0)
 -        os->keyframe_seek = 0;
 +//    if (ret < 0)
 +//        os->keyframe_seek = 0;
      return ret;
  }

-- 
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/438#comment:4>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list