[FFmpeg-trac] #1373(avcodec:open): bmv_video crash

[FFmpeg]

#1373: bmv_video crash
-------------------------------------+-------------------------------------
             Reporter:  ami_stuff    |                    Owner:
                 Type:  defect       |                   Status:  open
             Priority:  important    |                Component:  avcodec
              Version:  git-master   |               Resolution:
             Keywords:  bmv crash    |               Blocked By:
  SIGSEGV                            |  Reproduced by developer:  1
             Blocking:               |
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------

Comment (by richardpl):

 Here is fix, dunno if there is better one....

 {{{
 ---
  libavcodec/bmv.c |    2 ++
  1 file changed, 2 insertions(+)

 diff --git a/libavcodec/bmv.c b/libavcodec/bmv.c
 index 37c8448..fe10f16 100644
 --- a/libavcodec/bmv.c
 +++ b/libavcodec/bmv.c
 @@ -131,6 +131,8 @@ static int decode_bmv_frame(const uint8_t *source, int
 src_len, uint8_t *frame,
          }
          advance_mode = val & 1;
          len = (val >> 1) - 1;
 +        if (len <= 0)
 +            return -1;
          mode += 1 + advance_mode;
          if (mode >= 4)
              mode -= 3;
 }}}

-- 
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1373#comment:3>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker