[FFmpeg-trac] #1294(undetermined:open): Support for Omneon AVC Intra 50/100 MXF OP1a files
FFmpeg
trac at avcodec.org
Fri Sep 21 19:21:12 CEST 2012
#1294: Support for Omneon AVC Intra 50/100 MXF OP1a files
-------------------------------------+-------------------------------------
Reporter: Thomas | Owner:
Mundt | Status: open
Type: defect | Component:
Priority: normal | undetermined
Version: git-master | Resolution:
Keywords: h264intra | Blocked By:
mxf | Reproduced by developer: 1
Blocking: |
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
Comment (by reimar):
A few small comments:
1) If the SPS is now really correct, the code to set sample_aspect_ratio
should not be necessary anymore for these cases (and it should be in a
separate patch anyway since it has issues).
2) The "st->codec->codec_tag == MKTAG('a', 'i', '*', '2')" check makes no
sense, there is no ai*2 entry in isom.c, so it will never be true. If you
want a wildcard behaviour, use something like
uint32_t tmptag = codec_tag | MKTAG(0, 0, 0xff, 0);
if (tmptag == MKTAG('a', 'i', 0xff, '2') ...
But it would be nicer if field_order was set correctly in more than just
the 1080p/1080i case.
3) You copied the wrong placement of the // PPS comment from my code, the
PPS is the part starting with 00 00 00 01 68, so it should be one line
down.
I'd still find it nicer if we could generate those headers instead of
hard-coding the values, but I admit it's probably too much effort to
really be worth it.
--
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1294#comment:16>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list