[FFmpeg-trac] #2672(avfilter:closed): Incompatible avfilter_graph_parse()
FFmpeg
trac at avcodec.org
Wed Jul 3 13:32:05 CEST 2013
#2672: Incompatible avfilter_graph_parse()
-------------------------------------+-------------------------------------
Reporter: ubitux | Owner:
Type: defect | Status: closed
Priority: important | Component: avfilter
Version: git-master | Resolution: fixed
Keywords: api libav | Blocked By:
fork abi | Reproduced by developer: 1
Blocking: |
Analyzed by developer: 1 |
-------------------------------------+-------------------------------------
Changes (by saste):
* analyzed: 0 => 1
* keywords: => api libav fork abi
* status: new => closed
* resolution: => fixed
* reproduced: 0 => 1
Comment:
Replying to [ticket:2672 ubitux]:
> In 6119b23a, API was broken (on purpose):
>
> {{{
> int avfilter_graph_parse(AVFilterGraph *graph, const char *filters,
> - AVFilterInOut *inputs, AVFilterInOut *outputs,
> + AVFilterInOut **inputs, AVFilterInOut
**outputs,
> void *log_ctx);
> }}}
>
> While that API break was not really a problem at that time, the Libav
fork already existed and didn't pick that change. This causes an API
incompatibility between the two projects, which needs to be fixed somehow.
>
> AFAICT there is unfortunately no clean way to do that. Best we can do
seems to be to restore the prototype automatically at next major bump (but
that might break a lot of apps). Note that some applications are already
using this new prototypes.
Should be fixed in:
{{{
commit 838bd731393a29a41a86ff15ccf972f967306319
Author: Stefano Sabatini <stefasab at gmail.com>
Date: Tue Jul 2 01:39:14 2013 +0200
lavfi: create Libav-API compatibility layer for avfilter_graph_parse()
at the next bump
Add function avfilter_graph_parse_ptr() and favor it in place of
avfilter_graph_parse(), which will be restored with the old/Libav
signature at the next bump.
If HAVE_INCOMPATIBLE_LIBAV_API is enabled it will use the
Libav-compatible signature for avfilter_graph_parse().
At the next major bump the current implementation of
avfilter_graph_parse() should be dropped in favor of the Libav/old
implementation.
Should address trac ticket #2672.
}}}
--
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2672#comment:7>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list