[FFmpeg-trac] #3120(avcodec:open): Crash when converting internal SSA to SRT

FFmpeg trac at avcodec.org
Mon Nov 25 16:03:53 CET 2013


#3120: Crash when converting internal SSA to SRT
------------------------------------+-----------------------------------
             Reporter:  eelco       |                    Owner:
                 Type:  defect      |                   Status:  open
             Priority:  important   |                Component:  avcodec
              Version:  git-master  |               Resolution:
             Keywords:  ass crash   |               Blocked By:
             Blocking:              |  Reproduced by developer:  1
Analyzed by developer:  1           |
------------------------------------+-----------------------------------
Changes (by Cigaes):

 * analyzed:  0 => 1


Comment:

 The problem is that {{{srt_print}}} uses a fixed-size buffer and does not
 check for overflow with the {{{vsnprintf}}} return value.

 The easy solution is to add that kind of check and reject overly long
 lines. The good solution is to use a dynamic buffer, possibly AVBPrint.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/3120#comment:6>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list