[FFmpeg-trac] #3778(avformat:new): RTMPProto Overflow Interger (bytes_read) Bug

[FFmpeg]

#3778: RTMPProto Overflow Interger (bytes_read) Bug
-------------------------------------+------------------------------------
             Reporter:  rbarajas     |                    Owner:
                 Type:  defect       |                   Status:  new
             Priority:  normal       |                Component:  avformat
              Version:  unspecified  |               Resolution:
             Keywords:  rtmp         |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+------------------------------------

Comment (by rbarajas):

 We tested the attached patch and the issue still occurred. We contacted
 Adobe again and after a lot of testing and tracing we figured out that FMS
 requires the reset to happen at or close to 4,000,000,000. The fix we
 tried and confirmed it works as expected is the following.

 {{{
 if (rt->bytes_read - rt->last_bytes_read > rt->client_report_size) {
             av_log(s, AV_LOG_DEBUG, "Sending bytes read report\n");
             if ((ret = gen_bytes_read(s, rt, rpkt.timestamp + 1)) < 0)
                 return ret;
             if (rt->bytes_read > 4000000000)
                 rt->bytes_read = 0;
             rt->last_bytes_read = rt->bytes_read;
         }

 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/3778#comment:3>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker