[FFmpeg-trac] #2686(avcodec:open): Native AAC encoder collapses at high bitrates on some samples
FFmpeg
trac at avcodec.org
Sun May 18 04:33:42 CEST 2014
#2686: Native AAC encoder collapses at high bitrates on some samples
-------------------------------------+-------------------------------------
Reporter: Kamedo2 | Owner:
Type: defect | Status: open
Priority: normal | Component: avcodec
Version: git-master | Resolution:
Keywords: aac | Blocked By:
regression | Reproduced by developer: 1
Blocking: |
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
Comment (by cehoyos):
I am assuming that this patch is meant to be applied to FFmpeg git master
soon, the following is partly necessary, partly just a suggestion:
* The patch contains trailing white space, this cannot be pushed to our
git repository, please remove it. {{{tools/patcheck}}} can help you
finding such issues.
* Please either remove all printf's or make them av_log's.
* The function sqrf() is duplicated iiuc, please move it to a header (if
the function is necessary).
* There are three or four blocks where you just reindent existing code. It
makes reading your patch (in the future) easier if you don't reindent them
right now in the same commit, just leave them where they are. I can do the
reindent for you (or you can send a followup patch).
* And finally (purely optional):
Using the following
{{{
if (condition) {
do1;
} else {
do2;
}
}}}
instead of
{{{
if (condition)
do1;
else
do2;
}}}
has the advantage that future changes are smaller and easier to read (this
point is of course up to you, it is your code).
If you want me to make any of these changes and attach the result here,
please say so!
--
Ticket URL: <https://trac.ffmpeg.org/ticket/2686#comment:292>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list