[FFmpeg-trac] #4423(avformat:new): Set AV_DISPOSITION_ATTACHED_PIC for MKV Cover Art

FFmpeg trac at avcodec.org
Fri Apr 3 15:13:49 CEST 2015


#4423: Set AV_DISPOSITION_ATTACHED_PIC for MKV Cover Art
-----------------------------------+----------------------------------
             Reporter:  malaterre  |                     Type:  defect
               Status:  new        |                 Priority:  normal
            Component:  avformat   |                  Version:  2.6.1
             Keywords:             |               Blocked By:
             Blocking:             |  Reproduced by developer:  0
Analyzed by developer:  0          |
-----------------------------------+----------------------------------
 minidlna currently uses the following piece of code to find Cover Art:

 https://sourceforge.net/p/minidlna/git/ci/master/tree/libav.h#l171
 [...]
         if (s->disposition & AV_DISPOSITION_ATTACHED_PIC &&
             s->codec->codec_id == AV_CODEC_ID_MJPEG)
 [...]

 However the flag `AV_DISPOSITION_ATTACHED_PIC` is never set on MKV. Steps:

 Go here for MKV details on Cover Art mecanism:
 http://matroska.org/technical/cover_art/index.html

 Download sample:

 $ wget
 https://sourceforge.net/projects/matroska/files/test_files/cover_art.mkv
 $ ffprobe -show_streams cover_art.mkv
 [...]
 [STREAM]
 index=5
 codec_name=mjpeg
 codec_long_name=MJPEG (Motion JPEG)
 profile=unknown
 codec_type=attachment
 codec_time_base=0/1
 codec_tag_string=[0][0][0][0]
 codec_tag=0x0000
 id=N/A
 r_frame_rate=0/0
 avg_frame_rate=0/0
 time_base=1/90000
 start_pts=0
 start_time=0.000000
 duration_ts=14040000
 duration=156.000000
 bit_rate=N/A
 max_bit_rate=N/A
 bits_per_raw_sample=N/A
 nb_frames=N/A
 nb_read_frames=N/A
 nb_read_packets=N/A
 DISPOSITION:default=0
 DISPOSITION:dub=0
 DISPOSITION:original=0
 DISPOSITION:comment=0
 DISPOSITION:lyrics=0
 DISPOSITION:karaoke=0
 DISPOSITION:forced=0
 DISPOSITION:hearing_impaired=0
 DISPOSITION:visual_impaired=0
 DISPOSITION:clean_effects=0
 DISPOSITION:attached_pic=0
 TAG:filename=small_cover_land.jpg
 TAG:mimetype=image/jpeg
 [/STREAM]

--
Ticket URL: <https://trac.ffmpeg.org/ticket/4423>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list