[FFmpeg-trac] #4197(build system:new): libspeex detection is broken on systems without pkg-config

[FFmpeg]

#4197: libspeex detection is broken on systems without pkg-config
-------------------------------------+-------------------------------------
             Reporter:  cehoyos      |                    Owner:
                 Type:  defect       |                   Status:  new
             Priority:  important    |                Component:  build
              Version:  git-master   |  system
             Keywords:  libspeex     |               Resolution:
  regression                         |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------

Comment (by gajjanag):

 Replying to [comment:28 cehoyos]:
 > Replying to [comment:27 gajjanag]:
 > > @cehoyos: you rightly point out the inconsistency.
 > >
 > > I think what we need to do is make FFmpeg take a clear stance on this
 issue among some options:
 > > 1. We support pkg-config: in this case, we support it all the way, and
 add all required configure checks. I think very few people like this. I
 certainly don't.
 > >
 > > 2. We don't support pkg-config: in this case we remove all pkg-config
 checks, and add relevant documentation in visible places saying that pkg-
 config is a build dependency. I personally don't mind this. However, I
 vaguely recall some legitimate reasons for supporting builds without pkg-
 config.
 > >
 > > 3. We support pkg-config with some libraries and not with others: I
 consider this the most half baked option, but that is what we have
 currently. In this case, documentation must be in place for describing
 which external libs can be used without pkg-config, and which ones can't.
 This is annoying.
 >
 > We already agreed on having pkg-config as default and detection without
 pkg-config as fallback.

 Did not know that. It certainly does not feel that way since many
 developers are still not happy about this, and comments here and on the
 mailing list reflect a lack of agreement about this.
 I will give you the benefit of doubt on this one, and apologize for my
 negative attitude about this ticket.

 >
 > > BTW, in order to call it a regression, there should be proof that
 FFmpeg did support building without pkg-config at one point - I am not
 counting behavior in practice, but documentation. FFmpeg clearly
 delineates build platforms, I see no reason for why build tools (e.g pkg-
 config) should be different.
 > > In the absence of such proof, one can't call this a regression in my
 view. Otherwise, theoretically any change in undocumented behavior/state
 modifications can be called a "regression".
 >
 > A feature that breaks default detection of a library at least on aix,
 android, mingw and osx without any discussion or documentation is
 certainly a regression that cannot be fixed by an entry in the wiki (or
 the Changelog). But as said, this is trivial to fix, there should be no
 further discussion needed.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/4197#comment:29>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker