[FFmpeg-trac] #4449(avcodec:new): Error in mpegaudio_parser.c

[FFmpeg]

#4449: Error in mpegaudio_parser.c
------------------------------------+-----------------------------------
             Reporter:  Dan203      |                    Owner:
                 Type:  defect      |                   Status:  new
             Priority:  normal      |                Component:  avcodec
              Version:  git-master  |               Resolution:
             Keywords:  mpegaudio   |               Blocked By:
             Blocking:              |  Reproduced by developer:  0
Analyzed by developer:  0           |
------------------------------------+-----------------------------------

Comment (by heleppkes):

 Replying to [comment:2 Dan203]:
 > Any file with MP2 audio should be sufficient as a test case. After the
 call to avformat_find_stream_info the audio will not be detected as MP2.
 Only after the first call to av_read_frame does it get filled in
 correctly. I changed the parser as I described and it works correctly.

 "Working correctly" is a rather broad generalization. It works correctly
 for your file. Does it work correctly for every file? Probably not.

 By looking at that line alone, its quite obvious that your suggested
 change is incorrect, because the first condition would always be true if
 the second condition is also true, therefor it is redundant - which is a
 clear indicator that the original code was what the author intended.

 So instead, I would greatly recommend to provide a file with which the
 problem can be reproduced, and then we can see what can be done about it.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/4449#comment:4>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker