[FFmpeg-trac] #2686(avcodec:open): Native AAC encoder collapses at high bitrates on some samples

[FFmpeg]

#2686: Native AAC encoder collapses at high bitrates on some samples
-------------------------------------+-------------------------------------
             Reporter:  Kamedo2      |                    Owner:
                 Type:  defect       |  klaussfreire
             Priority:  normal       |                   Status:  open
              Version:  git-master   |                Component:  avcodec
             Keywords:  aac          |               Resolution:
  regression                         |               Blocked By:
             Blocking:               |  Reproduced by developer:  1
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------

Comment (by Kamedo2):

 You might be aware of this, but the recent push to the git head:
 "AAC: Add support for 7350Hz sampling rates, no error on too hight
 bitrate."
 {{{
 -    ERROR_IF(i >= 12,
 +    ERROR_IF(i == 16
 +                || i >= (sizeof(swb_size_1024) / sizeof(*swb_size_1024))
 +                || i >= (sizeof(swb_size_128) / sizeof(*swb_size_128)),
 }}}
 undid Michael Niedermayer's contribution:
 "avcodec/aacenc: Fix sample rate check".

 Fixes out of array read
 Fixes CID1257803, CID1257797, CID1257789, CID1257786
 {{{
 -    ERROR_IF(i == 16,
 +    ERROR_IF(i >= 12,
               "Unsupported sample rate %d\n", avctx->sample_rate);
      ERROR_IF(s->channels > AAC_MAX_CHANNELS,
               "Unsupported number of channels: %d\n", s->channels);
 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/2686#comment:368>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker