[FFmpeg-trac] #4547(avfilter:open): af_aphaser.c: segfault with low values of delay option

FFmpeg trac at avcodec.org
Mon May 11 15:37:30 CEST 2015


#4547: af_aphaser.c: segfault with low values of delay option
-------------------------------------+-------------------------------------
             Reporter:  gajjanag     |                    Owner:
                 Type:  defect       |                   Status:  open
             Priority:  important    |                Component:  avfilter
              Version:  git-master   |               Resolution:
             Keywords:  aphaser      |               Blocked By:
  crash SIGSEGV                      |  Reproduced by developer:  1
             Blocking:               |
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------

Comment (by gajjanag):

 Looking at the source and documentation for aphaser, I see some other
 things that could be improved. I list them below; please let me know if
 you want a separate ticket for them.

 1. Documentation is somewhat incomplete - it lists the default values, but
 not the max or the min values.

 2. The code has a bunch of "magic" constants representing the max and the
 min. From my understanding of the source code, many of them are not really
 fundamental and arbitrarily constrain the user, e.g modulation speed must
 be between 0.1 and 2. I think some rationale should be offered, e.g as a
 comment in the code, or if they are not necessary, the constraints should
 be made more appropriate.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/4547#comment:6>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list