[FFmpeg-trac] #5231(avcodec:closed): Crashes in ff_deblock_v_luma_8_sse2
FFmpeg
trac at avcodec.org
Fri Oct 7 18:25:10 EEST 2016
#5231: Crashes in ff_deblock_v_luma_8_sse2
-------------------------------------+-------------------------------------
Reporter: mi | Owner:
Type: defect | Status: closed
Priority: important | Component: avcodec
Version: git-master | Resolution: fixed
Keywords: h264 crash | Blocked By:
SIGSEGV | Reproduced by developer: 1
Blocking: |
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
Comment (by mi):
Replying to [comment:24 cehoyos]:
{{{
--- a/configure
+++ b/configure
@@ -6202,6 +6202,7 @@ elif enabled llvm_gcc; then
check_cflags -mllvm -stack-alignment=16
elif enabled clang; then
check_cflags -mllvm -stack-alignment=16
+ check_cflags -mstack-alignment=16
check_cflags -Qunused-arguments
check_cflags -Werror=implicit-function-declaration
check_cflags -Werror=missing-prototypes
}}}
Does this not cause a pessimization in other parts of the code, though?
That was my worry -- that by setting the stack-alignment to a non-default
value to solve a problem in one function slows things down (or increases
memory use) everywhere else...
> Thanks to Mikhail
You are welcome. I'll keep your account on the box active. In addition to
clang-3.4.1 (a.k.a. `cc`) and gcc-4.2.1 (a.k.a. `gcc`), it has the latest
versions of clang-3.6 (`clang36`), 3.7 (`clang37`), 3.8 (`clang38`) and
gcc-6 (`gcc6`). You are most welcome -- indeed ''encouraged'' -- to
routinely test with any/all of these compilers. Thank you!
--
Ticket URL: <https://trac.ffmpeg.org/ticket/5231#comment:25>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list