[FFmpeg-trac] #4450(undetermined:open): Copying subtitle streams aborts w/non monotonically increasing dts

[FFmpeg]

#4450: Copying subtitle streams aborts w/non monotonically increasing dts
-------------------------------------+-------------------------------------
             Reporter:  forbyta      |                    Owner:
                 Type:  defect       |                   Status:  open
             Priority:  normal       |                Component:
              Version:  git-master   |  undetermined
             Keywords:               |               Resolution:
  av_interleaved_write_frame mpegps  |               Blocked By:
  dvdsub                             |  Reproduced by developer:  1
             Blocking:               |
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------

Comment (by forbyta):

 I retested the original "fix" with the latest ffmpeg (N-84804-g247d033)
 and it still works.

 The same change also appears to fix [https://trac.ffmpeg.org/ticket/6248]


 Here's a diff of the single line change:

 {{{
 diff -u ffmpeg-master/ffmpeg.c ffmpeg-master-dts/ffmpeg.c
 --- ffmpeg-master/ffmpeg.c      2017-03-29 12:33:47.038626570 -0700
 +++ ffmpeg-master-dts/ffmpeg.c  2017-03-29 15:02:33.732864853 -0700
 @@ -751,7 +751,7 @@
                       - FFMIN3(pkt->pts, pkt->dts, ost->last_mux_dts + 1)
                       - FFMAX3(pkt->pts, pkt->dts, ost->last_mux_dts + 1);
          }
 -        if ((st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO ||
 st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO) &&
 +        if ((st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO ||
 st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO || st->codecpar->codec_type
 == AVMEDIA_TYPE_SUBTITLE) &&
              pkt->dts != AV_NOPTS_VALUE &&
              !(st->codecpar->codec_id == AV_CODEC_ID_VP9 &&
 ost->stream_copy) &&
              ost->last_mux_dts != AV_NOPTS_VALUE) {
 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/4450#comment:6>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker