[FFmpeg-trac] #6742(avformat:closed): ffmpeg-3.4/libavformat/nutdec.c:585: suspicious if ?

FFmpeg trac at avcodec.org
Fri Dec 14 00:07:12 EET 2018


#6742: ffmpeg-3.4/libavformat/nutdec.c:585: suspicious if ?
------------------------------------+------------------------------------
             Reporter:  dcb         |                    Owner:
                 Type:  defect      |                   Status:  closed
             Priority:  normal      |                Component:  avformat
              Version:  git-master  |               Resolution:  invalid
             Keywords:  nut         |               Blocked By:
             Blocking:              |  Reproduced by developer:  1
Analyzed by developer:  0           |
------------------------------------+------------------------------------

Comment (by dcb):

 Suggest have another look, using Mark 1 eyeball.

 Original code says something like

 if (num >= 1000 * den
   || num < 0 || num < 0)

 That looks wrong to me. Suggest new code

 if (num >= 1000 * den
   || num < 0 || den < 0)

 Looks a bit more rational to me.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/6742#comment:5>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list