[FFmpeg-trac] #6742(avformat:reopened): ffmpeg-3.4/libavformat/nutdec.c:585: suspicious if ?
FFmpeg
trac at avcodec.org
Tue Nov 27 18:32:10 EET 2018
#6742: ffmpeg-3.4/libavformat/nutdec.c:585: suspicious if ?
------------------------------------+------------------------------------
Reporter: dcb | Owner:
Type: defect | Status: reopened
Priority: normal | Component: avformat
Version: git-master | Resolution:
Keywords: nut | Blocked By:
Blocking: | Reproduced by developer: 1
Analyzed by developer: 0 |
------------------------------------+------------------------------------
Changes (by cehoyos):
* status: closed => reopened
* component: undetermined => avformat
* version: unspecified => git-master
* keywords: => nut
* resolution: wontfix =>
* reproduced: 0 => 1
Old description:
> [ffmpeg-3.4/libavformat/nutdec.c:585]: (style) Same expression on both
> sides of '||'.
>
> Source code is
>
> if (st->r_frame_rate.num >= 1000LL*st->r_frame_rate.den
> ||
> st->r_frame_rate.num < 0 || st->r_frame_rate.num < 0)
>
> maybe better code
>
> if (st->r_frame_rate.num >= 1000LL*st->r_frame_rate.den
> ||
> st->r_frame_rate.num < 0 || st->r_frame_rate.den < 0)
New description:
[ffmpeg-3.4/libavformat/nutdec.c:585]: (style) Same expression on both
sides of '||'.
Source code is
{{{
if (st->r_frame_rate.num >= 1000LL*st->r_frame_rate.den ||
st->r_frame_rate.num < 0 || st->r_frame_rate.num < 0)
}}}
maybe better code
{{{
if (st->r_frame_rate.num >= 1000LL*st->r_frame_rate.den ||
st->r_frame_rate.num < 0 || st->r_frame_rate.den < 0)
}}}
--
--
Ticket URL: <https://trac.ffmpeg.org/ticket/6742#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list