[FFmpeg-trac] #7859(avformat:new): Wrong ARMovie audio codec detection

FFmpeg trac at avcodec.org
Thu Apr 25 01:52:39 EEST 2019


#7859: Wrong ARMovie audio codec detection
-------------------------------------+------------------------------------
             Reporter:  stohrendorf  |                    Owner:
                 Type:  defect       |                   Status:  new
             Priority:  normal       |                Component:  avformat
              Version:  git-master   |               Resolution:
             Keywords:  rpl          |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+------------------------------------
Changes (by cehoyos):

 * keywords:   => rpl


Comment:

 Please test this patch:
 {{{
 diff --git a/libavformat/rpl.c b/libavformat/rpl.c
 index fa63576..7aec350 100644
 --- a/libavformat/rpl.c
 +++ b/libavformat/rpl.c
 @@ -210,10 +210,10 @@ static int rpl_read_header(AVFormatContext *s)
                      ast->codecpar->codec_id = AV_CODEC_ID_PCM_S16LE;
                      break;
                  } else if (ast->codecpar->bits_per_coded_sample == 8) {
 -                    if(strstr(audio_type, "unsigned") != NULL) {
 +                    if(av_strcasecmp(audio_type, "unsigned") >= 0) {
                          ast->codecpar->codec_id = AV_CODEC_ID_PCM_U8;
                          break;
 -                    } else if(strstr(audio_type, "linear") != NULL) {
 +                    } else if(av_strcasecmp(audio_type, "linear") >= 0) {
                          ast->codecpar->codec_id = AV_CODEC_ID_PCM_S8;
                          break;
                      } else {
 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/7859#comment:3>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list