[FFmpeg-trac] #6741(avfilter:closed): ffmpeg-3.4/libavfilter/vf_cover_rect.c:155: suspicious if ?

[FFmpeg]

#6741: ffmpeg-3.4/libavfilter/vf_cover_rect.c:155: suspicious if ?
------------------------------------+------------------------------------
             Reporter:  dcb         |                    Owner:
                 Type:  defect      |                   Status:  closed
             Priority:  normal      |                Component:  avfilter
              Version:  git-master  |               Resolution:  fixed
             Keywords:              |               Blocked By:
             Blocking:              |  Reproduced by developer:  0
Analyzed by developer:  0           |
------------------------------------+------------------------------------
Changes (by cehoyos):

 * status:  new => closed
 * resolution:   => fixed
 * version:  unspecified => git-master
 * component:  undetermined => avfilter


Old description:

> ffmpeg-3.4/libavfilter/vf_cover_rect.c:155] ->
> [ffmpeg-3.4/libavfilter/vf_cover_rect.c:155]: (style) Same expression on
> both sides of '||'.
>
> Source code is
>
>     if (!xendptr || *xendptr || !yendptr || *yendptr ||
>         !wendptr || *wendptr || !hendptr || !hendptr
>
> maybe better code
>
>     if (!xendptr || *xendptr || !yendptr || *yendptr ||
>         !wendptr || *wendptr || !hendptr || !*hendptr

New description:

 ffmpeg-3.4/libavfilter/vf_cover_rect.c:155] ->
 [ffmpeg-3.4/libavfilter/vf_cover_rect.c:155]: (style) Same expression on
 both sides of `||`.

 Source code is
 {{{
     if (!xendptr || *xendptr || !yendptr || *yendptr ||
         !wendptr || *wendptr || !hendptr || !hendptr
 }}}
 maybe better code
 {{{
     if (!xendptr || *xendptr || !yendptr || *yendptr ||
         !wendptr || *wendptr || !hendptr || !*hendptr
 }}}

--

Comment:

 Fixed by Jun Zhao in c9671289521226dd7d3213377a14331e73cb6283

--
Ticket URL: <https://trac.ffmpeg.org/ticket/6741#comment:1>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker