[FFmpeg-trac] #8156(undetermined:open): PVS-studio big list of errors

FFmpeg trac at avcodec.org
Mon Sep 16 22:42:59 EEST 2019


#8156: PVS-studio big list of errors
-------------------------------------+-------------------------------------
             Reporter:  Balling      |                    Owner:
                 Type:  defect       |                   Status:  open
             Priority:  normal       |                Component:
                                     |  undetermined
              Version:  unspecified  |               Resolution:
             Keywords:               |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------
Changes (by Balling):

 * status:  new => open


Comment:

 So, in commits
 https://github.com/FFmpeg/FFmpeg/commit/7a7aa4f79e506eff8bddb971da2b7cf0dac7d009
 and
 https://github.com/FFmpeg/FFmpeg/commit/dc3325076597b41e0e05f201df2a8a84f588006d
 you already solved my comments on twice assignment in first comment. So I
 will add all other cases of "twice":

 {{{
 ./libavfilter/vf_ciescope.c     1195    warn    V519 The 'wx' variable is
 assigned values twice successively. Perhaps this is a mistake. Check
 lines: 1193, 1195.
 ./libavfilter/vf_ciescope.c     1196    warn    V519 The 'wy' variable is
 assigned values twice successively. Perhaps this is a mistake. Check
 lines: 1194, 1196.
 ./libavfilter/vf_ciescope.c     1202    warn    V519 The 'wx' variable is
 assigned values twice successively. Perhaps this is a mistake. Check
 lines: 1200, 1202.
 ./libavfilter/vf_ciescope.c     1203    warn    V519 The 'wy' variable is
 assigned values twice successively. Perhaps this is a mistake. Check
 lines: 1201, 1203.
 ./libavformat/asfdec_o.c        1147    warn    V519 The
 'asf_pkt->duration' variable is assigned values twice successively.
 Perhaps this is a mistake. Check lines: 1144, 1147.
 ./libavformat/asfdec_o.c        1561    warn    V519 The 'pkt->duration'
 variable is assigned values twice successively. Perhaps this is a mistake.
 Check lines: 1558, 1561.
 ./libavformat/dhav.c    198     warn    V519 The 'ret' variable is
 assigned values twice successively. Perhaps this is a mistake. Check
 lines: 189, 198.
 ./libavformat/segment.c 393     warn    V519 The
 'seg->segment_list_entries_end' variable is assigned values twice
 successively. Perhaps this is a mistake. Check lines: 390, 393.
 ./libavcodec/dirac_parser.c     263     warn    V519 The '* poutbuf'
 variable is assigned values twice successively. Perhaps this is a mistake.
 Check lines: 250, 263.
 ./libavcodec/dirac_parser.c     264     warn    V519 The '* poutbuf_size'
 variable is assigned values twice successively. Perhaps this is a mistake.
 Check lines: 251, 264.
 ./libavcodec/hevcpred_template.c        224     warn    V519 The 'left[-
 1]' variable is assigned values twice successively. Perhaps this is a
 mistake. Check lines: 209, 224.
 ./libavcodec/snowenc.c  344     warn    V519 The 'ref_score' variable is
 assigned values twice successively. Perhaps this is a mistake. Check
 lines: 343, 344.
 ./libavcodec/vaapi_encode_mpeg2.c       331     warn    V519 The
 'ph->forward_f_code' variable is assigned values twice successively.
 Perhaps this is a mistake. Check lines: 329, 331.
 ./fftools/ffmpeg_filter.c       731     warn    V519 The 'ifilter->width'
 variable is assigned values twice successively. Perhaps this is a mistake.
 Check lines: 728, 731.
 ./fftools/ffmpeg_filter.c       732     warn    V519 The 'ifilter->height'
 variable is assigned values twice successively. Perhaps this is a mistake.
 Check lines: 729, 732.
 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/8156#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list