[FFmpeg-trac] #8156(undetermined:open): PVS-studio big list of errors

[FFmpeg]

#8156: PVS-studio big list of errors
-------------------------------------+-------------------------------------
             Reporter:  Balling      |                    Owner:
                 Type:  defect       |                   Status:  open
             Priority:  normal       |                Component:
                                     |  undetermined
              Version:  unspecified  |               Resolution:
             Keywords:               |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------

Comment (by Balling):

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/vf_dedot.c#L343
 !s->eof is always true.
 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/vf_deflicker.c#L393
 I suppose no need to check metadata because we do dereference pointer to
 struct on previous line which is not NULL and a field inside struct will
 not have NULL address ever...
 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/vf_detelecine.c#L224
 Not need to check nskip_fields is unsigned int... But maybe add a
 comment))
 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/vf_fftdnoiz.c#L624
 We are inside if which checks for this! s->nb_next > 0 can be deleted

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/vf_fftfilt.c#L324
 This else is not possible)) I suppose. All variants are already checked.

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/vf_fieldmatch.c#L779-L781
 Strange that this is the same as on lines 765, 766

 https://github.com/FFmpeg/FFmpeg/blob/ef50cf7b32b91af303e37236f22e2e89971a84b7/libavfilter/vf_hqdn3d.c#L183
 Negative value left shift... You like it))

--
Ticket URL: <https://trac.ffmpeg.org/ticket/8156#comment:6>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker