[FFmpeg-trac] #8466(avformat:closed): av_url_split violates RFC2396, fails to parse URLs

FFmpeg trac at avcodec.org
Sun Feb 16 01:31:31 EET 2020


#8466: av_url_split violates RFC2396, fails to parse URLs
-------------------------------------+------------------------------------
             Reporter:  aitte        |                    Owner:
                 Type:  defect       |                   Status:  closed
             Priority:  normal       |                Component:  avformat
              Version:  unspecified  |               Resolution:  fixed
             Keywords:  http         |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+------------------------------------
Changes (by cus):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:7 aitte]:
 > Note how the code is adding a "/" slash if the first character of the
 path is a question mark. Is there any problem if the URL is
 "https://example.com#foo"?
 >
 > It looks to me like the hashmark check a few lines earlier (
 https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=987ce96d41d21a120e6109f9bb1e3a9dcddbf30b
 ) puts a null byte at the hashmark position to "erase the hashmark and
 everything after it" already, so I guess there is no problem! Just asking
 to be sure. :-)

 Yeah, that should be fine as well, empty path (it becomes empty after
 removing the hashmark) was converted to / even before this patchset.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/8466#comment:8>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list