[FFmpeg-trac] #8043(avformat:reopened): Nero and Quicktime format chapters
FFmpeg
trac at avcodec.org
Fri Jan 31 19:37:35 EET 2020
#8043: Nero and Quicktime format chapters
-------------------------------------+------------------------------------
Reporter: Naqros | Owner:
Type: enhancement | Status: reopened
Priority: wish | Component: avformat
Version: git-master | Resolution:
Keywords: mov | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
-------------------------------------+------------------------------------
Comment (by Naqros):
Replying to [comment:1 cehoyos]:
> Does the following change (inlined) fix the chapters for you?
> {{{
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index fb44ee2c71..29ff5c46e4 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -6285,7 +6285,7 @@ static int mov_init(AVFormatContext *s)
> }
>
> mov->nb_streams = s->nb_streams;
> - if (mov->mode & (MODE_MP4|MODE_MOV|MODE_IPOD) && s->nb_chapters)
> + if (0 && mov->mode & (MODE_MP4|MODE_MOV|MODE_IPOD) &&
s->nb_chapters)
> mov->chapter_track = mov->nb_streams++;
>
> if (mov->flags & FF_MOV_FLAG_RTP_HINT) {
> @@ -6821,7 +6821,7 @@ static int mov_write_trailer(AVFormatContext *s)
> // If there were no chapters when the header was written, but there
> // are chapters now, write them in the trailer. This only works
> // when we are not doing fragments.
> - if (!mov->chapter_track && !(mov->flags & FF_MOV_FLAG_FRAGMENT)) {
> + if (0 && !mov->chapter_track && !(mov->flags &
FF_MOV_FLAG_FRAGMENT)) {
> if (mov->mode & (MODE_MP4|MODE_MOV|MODE_IPOD) &&
s->nb_chapters) {
> mov->chapter_track = mov->nb_streams++;
> if ((res = mov_create_chapter_track(s, mov->chapter_track))
< 0)
> }}}
Any idea why this wouldn't be working for me in Linux? Worked perfectly
after compiling for Windows, but I've tried a few times and can't get it
to not create the Quicktime chapters after compiling in Linux.
--
Ticket URL: <https://trac.ffmpeg.org/ticket/8043#comment:4>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list