[FFmpeg-trac] #8760(avformat:new): srt updated, ffmpeg's libsrt no longer builds

[FFmpeg]

#8760: srt updated, ffmpeg's libsrt no longer builds
-----------------------------------+--------------------------------------
             Reporter:  hydra3333  |                     Type:  defect
               Status:  new        |                 Priority:  important
            Component:  avformat   |                  Version:  git-master
             Keywords:             |               Blocked By:
             Blocking:             |  Reproduced by developer:  0
Analyzed by developer:  0          |
-----------------------------------+--------------------------------------
 Summary of the bug:
 Upstream srt commit
 https://github.com/Haivision/srt/commit/0e2201aff6b379979cec43fee5e8f162717f6346
 causes ffmpeg's libsrt to no longer build.

 An issue there
 https://github.com/Haivision/srt/issues/1382#issuecomment-650241468
 says ffmpeg needs to be updated.

 ffmpeg (static) build Log:

 How to reproduce:
 try to build ffmpeg with srt as a dependency when srt has been built from
 their latest git master.

 {{{
 CC      libavformat/librtmp.o
 CC      libavformat/libsrt.o
 libavformat/libopenmpt.c: In function 'read_probe_openmpt':
 libavformat/libopenmpt.c:251:41: warning: passing argument 1 of
 'probe_openmpt_extension' discards 'const' qualifier from pointer target
 type [-Wdiscarded-qualifiers]
   251 |             if (probe_openmpt_extension(p) > 0) {
       |                                         ^
 libavformat/libopenmpt.c:221:49: note: expected 'AVProbeData *' but
 argument is of type 'const AVProbeData *'
   221 | static int probe_openmpt_extension(AVProbeData *p)
       |                                    ~~~~~~~~~~~~~^
 libavformat/libopenmpt.c:274:36: warning: passing argument 1 of
 'probe_openmpt_extension' discards 'const' qualifier from pointer target
 type [-Wdiscarded-qualifiers]
   274 |     return probe_openmpt_extension(p);
       |                                    ^
 libavformat/libopenmpt.c:221:49: note: expected 'AVProbeData *' but
 argument is of type 'const AVProbeData *'
   221 | static int probe_openmpt_extension(AVProbeData *p)
       |                                    ~~~~~~~~~~~~~^
 CC      libavformat/lmlm4.o
 CC      libavformat/loasdec.o
 CC      libavformat/lrc.o
 CC      libavformat/lrcdec.o
 libavformat/libsrt.c: In function 'libsrt_set_options_pre':
 libavformat/libsrt.c:317:66: error: 'SRTO_STRICTENC' undeclared (first use
 in this function); did you mean 'SRTO_STATE'?
   317 |         (s->enforced_encryption >= 0 && libsrt_setsockopt(h, fd,
 SRTO_STRICTENC, "SRTO_STRICTENC", &s->enforced_encryption,
 sizeof(s->enforced_encryption)) < 0) ||
       |
 ^~~~~~~~~~~~~~
       |
 SRTO_STATE
 libavformat/libsrt.c:317:66: note: each undeclared identifier is reported
 only once for each function it appears in
 libavformat/libsrt.c:336:50: error: 'SRTO_SMOOTHER' undeclared (first use
 in this function); did you mean 'SRTO_SENDER'?
   336 |         (s->smoother && libsrt_setsockopt(h, fd, SRTO_SMOOTHER,
 "SRTO_SMOOTHER", s->smoother, strlen(s->smoother)) < 0) ||
       |                                                  ^~~~~~~~~~~~~
       |                                                  SRTO_SENDER
 libavformat/libsrt.c: In function 'libsrt_setup':
 libavformat/libsrt.c:409:5: warning: 'srt_socket' is deprecated
 [-Wdeprecated-declarations]
   409 |     fd = srt_socket(cur_ai->ai_family, cur_ai->ai_socktype, 0);
       |     ^~
 In file included from libavformat/libsrt.c:24:
 /home/u/Desktop/_working/workdir/toolchain/x86_64-w64-mingw32/include/srt/srt.h:735:41:
 note: declared here
   735 | SRT_ATR_DEPRECATED_PX SRT_API SRTSOCKET srt_socket(int, int, int)
 SRT_ATR_DEPRECATED;
       |                                         ^~~~~~~~~~
 make: *** [ffbuild/common.mak:59: libavformat/libsrt.o] Error 1
 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/8760>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker