[FFmpeg-trac] #8505(avcodec:open): fast aac encoder produces invalid output for x86 32-bit builds
FFmpeg
trac at avcodec.org
Thu Mar 5 14:57:14 EET 2020
#8505: fast aac encoder produces invalid output for x86 32-bit builds
-------------------------------------+-------------------------------------
Reporter: | Owner:
LeadAssimilator |
Type: defect | Status: open
Priority: important | Component: avcodec
Version: git-master | Resolution:
Keywords: regression | Blocked By:
aac |
Blocking: | Reproduced by developer: 1
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
Comment (by LeadAssimilator):
Do you mean use sse instead of sse2? quant doesn't need any specific sse2
instructions and can be implemented in sse only. But
ff_aac_quantize_bands_sse2 is used when sse2 is available, so a sse
version of quant would also have to only be used when sse2 is available.
Using a sse quant when sse2 is available would fix the problem when run on
x86 with sse2, but not when run on x86 without sse2 (old cpus or embedded
socs like intel quark for example) and compiling with -Os, -O1 or better.
The sse quant would also have to be called via a function pointer like
other hand optimized functions. The performance impact should be
negligible, but isn't correctness to prevent corrupted output more
important here?
--
Ticket URL: <https://trac.ffmpeg.org/ticket/8505#comment:23>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list