[FFmpeg-trac] #8549(ffplay:closed): A memory leak in ffplay

[FFmpeg]

#8549: A memory leak in ffplay
-------------------------------------+----------------------------------
             Reporter:  elite_jwp    |                    Owner:  cus
                 Type:  defect       |                   Status:  closed
             Priority:  normal       |                Component:  ffplay
              Version:  unspecified  |               Resolution:  fixed
             Keywords:  leak         |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+----------------------------------
Changes (by mkver):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 av_packet_unref(&pkt) does not directly free pkt.data (pkt is not a
 pointer here, hence pkt->data would not even compile); instead it just
 unreferences the AVBufferRef pkt.buf (and the packet's side-data) and only
 if the reference counter of the underlying AVBuffer is zero will the
 actual resource owned by the AVBuffer be freed. But flush_pkt.buf is NULL,
 i.e. there is no underlying AVBuffer. The data field is used here only to
 say "I am a flush packet". Nothing will be freed in case pkt.data ==
 flush_pkt.data.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/8549#comment:6>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker