[FFmpeg-trac] #9389(avcodec:new): [regression] Film Grain breaks h264_vaapi

[FFmpeg]

#9389: [regression] Film Grain breaks h264_vaapi
-------------------------------------+-------------------------------------
             Reporter:  U. Artie     |                    Owner:  (none)
  Eoff                               |
                 Type:  defect       |                   Status:  new
             Priority:  critical     |                Component:  avcodec
              Version:  unspecified  |               Resolution:
             Keywords:  regression,  |               Blocked By:
  vaapi                              |
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------
Comment (by James):

 Does the following fix it for you?


 {{{
 diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
 index 3063ee069a..201b22455c 100644
 --- a/libavcodec/h264_slice.c
 +++ b/libavcodec/h264_slice.c
 @@ -527,7 +527,7 @@ static int h264_frame_start(H264Context *h)
      pic->f->crop_top    = h->crop_top;
      pic->f->crop_bottom = h->crop_bottom;

 -    pic->needs_fg = h->sei.film_grain_characteristics.present &&
 +    pic->needs_fg = h->sei.film_grain_characteristics.present &&
 !h->avctx->hwaccel &&
          !(h->avctx->export_side_data & AV_CODEC_EXPORT_DATA_FILM_GRAIN);

      if ((ret = alloc_picture(h, pic)) < 0)
 }}}
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/9389#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker