[FFmpeg-trac] #9344(avformat:new): ffmpeg segfaults on quicktime files with large samples

[FFmpeg]

#9344: ffmpeg segfaults on quicktime files with large samples
------------------------------------+------------------------------------
             Reporter:  Bruce       |                    Owner:  (none)
                 Type:  defect      |                   Status:  new
             Priority:  normal      |                Component:  avformat
              Version:  git-master  |               Resolution:
             Keywords:  mov         |               Blocked By:
             Blocking:              |  Reproduced by developer:  0
Analyzed by developer:  0           |
------------------------------------+------------------------------------
Comment (by Bruce):

 Replying to [comment:1 mkver]:
 > Can you test [https://ffmpeg.org/pipermail/ffmpeg-
 devel/2021-July/282604.html this patch]?

 This patch fixes the crash:

 ./ffmpeg -i vid1.mov
 ffmpeg version N-103056-g4ff73add5d Copyright (c) 2000-2021 the FFmpeg
 developers
   built with Apple clang version 11.0.3 (clang-1103.0.32.62)
   configuration: --enable-debug --disable-optimizations
   libavutil      57.  2.100 / 57.  2.100
   libavcodec     59.  3.102 / 59.  3.102
   libavformat    59.  4.101 / 59.  4.101
   libavdevice    59.  0.100 / 59.  0.100
   libavfilter     8.  0.103 /  8.  0.103
   libswscale      6.  0.100 /  6.  0.100
   libswresample   4.  0.100 /  4.  0.100
 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fe091c11680] error reading header
 vid1.mov: Invalid data found when processing input

 I wonder why the return code from the call to init_get_bits is not
 checked. Seems like some places in the code check it, but others do not.
 What is the rationale?  Thanks!

 Bruce
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/9344#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker