[FFmpeg-trac] #9263(fate:new): some FATE tests incorrectly set bitexact flag

FFmpeg trac at avcodec.org
Wed May 26 11:39:02 EEST 2021


#9263: some FATE tests incorrectly set bitexact flag
-------------------------------------+-------------------------------------
             Reporter:  Ilya         |                     Type:  defect
  Kurdyukov                          |
               Status:  new          |                 Priority:  normal
            Component:  fate         |                  Version:
                                     |  unspecified
             Keywords:               |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------
 I'm making a SIMD optimization patch for the Elbrus architecture (e2k).

 I have a failed test "avid/avidmeridianntsc.mov", because I have a faster,
 not bitexact IDCT, which is not selected if AV_CODEC_FLAG_BITEXACT is set.
 But the test itself falsely set the -bitexact flag, so when it comes to
 ff_idctdsp_init_e2k() - this condition:
 {{{
 (avctx->idct_algo == FF_IDCT_AUTO && !(avctx->flags &
 AV_CODEC_FLAG_BITEXACT))
 }}}
 ...is true, avctx->flags are zero.

 From the FATE log:
 {{{
 ffmpeg -nostdin -nostats -noauto_conversion_filters -cpuflags all -hwaccel
 none -threads 1 -thread_type frame+slice -i ../fate-
 suite/avid/avidmeridianntsc.mov -bitexact -f framecrc -
 }}}

 I found that the -bitexact option must come before "-i filename" for this
 to work correctly, not after the filename.

 I'm working with ffmpeg version 4.4 (from 8 Apr 2021) sources right now.
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/9263>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list