[FFmpeg-trac] #10848(undetermined:new): Crackling when concatenating audio introduced in commit d85c6aba

[FFmpeg]

#10848: Crackling when concatenating audio introduced in commit d85c6aba
-------------------------------------+-------------------------------------
             Reporter:  jonnyburger  |                    Owner:  (none)
                 Type:  defect       |                   Status:  new
             Priority:  normal       |                Component:
                                     |  undetermined
              Version:  unspecified  |               Resolution:
             Keywords:               |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------
Comment (by jonnyburger):

 Absolutely, here is the difference between the outputs. 6_0.mp4 sounds
 good, 6_1 does not. The change in source code is only:

 >
 > {{{
 > diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c
 > index fcee8b65ac..07edcef4f2 100644
 > --- a/fftools/ffmpeg_dec.c
 > +++ b/fftools/ffmpeg_dec.c
 > @@ -214,7 +214,7 @@ static void audio_ts_process(void *logctx, Decoder
 *d, AVFrame *frame)
 >      // on samplerate change, choose a new internal timebase for
 timestamp
 >      // generation that can represent timestamps from all the
 samplerates
 >      // seen so far
 > -    tb = audio_samplerate_update(logctx, d, frame);
 > +    tb = frame->time_base;
 >      pts_pred = d->last_frame_pts == AV_NOPTS_VALUE ? 0 :
 >                 d->last_frame_pts + d->last_frame_duration_est;
 > }}}
 >
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/10848#comment:9>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker