[FFmpeg-trac] #11194(avformat:new): image2 frame_pts integer overflow
FFmpeg
trac at avcodec.org
Tue Sep 17 07:17:05 EEST 2024
#11194: image2 frame_pts integer overflow
-------------------------------------+-------------------------------------
Reporter: Filip | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: avformat
Version: git-master | Resolution:
Keywords: image2 | Blocked By:
frame_pts |
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
Comment (by Filip):
[https://ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333602.html]
New patch, supersedes the last one. The change is implemented as non–ABI-
breaking, with the introduction of av_get_frame_filename**3**, but it
raises the issue of the old implementations kicking around, which should
probably be deprecated (with the changes announced in the API changelog).
I decided this is a necessary change to support the frame_pts option
properly since the old code had a lossy narrowing type conversion that
caused this defect, and making an entirely new codepath would've made the
interface of frame_pts (relying on things like a custom parsing routine
for the filename template "%d" specifier) incompatible with the rest of
img2enc. The new implementation should be totally backwards-compatible but
I still can't test it myself since I can't get make to work on WSL lol.
Regression tests are passed though:
[https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=12886].
--
Ticket URL: <https://trac.ffmpeg.org/ticket/11194#comment:3>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list