[FFmpeg-user] can't build today's git with qsv

[sean darcy]

On 11/26/19 3:03 PM, sean darcy wrote:
> On 11/26/19 12:28 PM, Carl Eugen Hoyos wrote:
>> Am Mo., 25. Nov. 2019 um 23:45 Uhr schrieb sean darcy 
>> <seandarcy2 at gmail.com>:
>>>
>>> On Fedora 31, today's git:
>>>
>>> libavcodec/qsvenc.c: In function 'qsv_retrieve_enc_vp9_params':
>>> libavcodec/qsvenc.c:827:25: error: 'vp9_extend_buf' undeclared (first
>>> use in th>
>>>     827 |         (mfxExtBuffer*)&vp9_extend_buf,
>>>         |                         ^~~~~~~~~~~~~~
>>
>> Please test the following inlined patch:
>>
>> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
>> index 93d49ba21d..1bc5600061 100644
>> --- a/libavcodec/qsvenc.c
>> +++ b/libavcodec/qsvenc.c
>> @@ -824,7 +824,9 @@
>>   #endif
>>
>>       mfxExtBuffer *ext_buffers[] = {
>> +#if QSV_HAVE_EXT_VP9_PARAM
>>           (mfxExtBuffer*)&vp9_extend_buf,
>> +#endif
>>   #if QSV_HAVE_CO2
>>           (mfxExtBuffer*)&co2,
>>   #endif
>>
>>
>> Unrelated:
>> The configure option arch does not do what you think it does,
>> remove it.
>> I suggest you remove the optflags: Yours do not look completely
>> insane (as they usually are) but setting them is still a good way
>> to break compilation.
>> Not sure if enable-bzlib has an effect, I recommend to remove
>> it to make the configure line more readable.
>> disable-libdav1d looks useless.
>> enable-vaapi has no effect.
>> enable-stripping is the default
>> enable-postproc has no effect
>> enable-runtime-cpudetect does not do what you think it does,
>> remove it.
>> enable-indev=jack has no effect
>> enable-nonfree is only needed once
>> enable-avfilter has no effect
>>
>> Carl Eugen
> 
> Yesterday's git with the patch built.
> 
> I'll sort out the config options. They haven't been reviewed in probably 
> 10 years, just new ones added.
> 
> Thanks for the prompt response.
> 
> sean
> 
Well one reason to have superfluous --enable options, is so you can 
remember how to disable them. For instance, stripping isn't working.

strip -o ffprobe ffprobe_g
strip:ffprobe_g[.gnu.build.attributes]: corrupt GNU build attribute 
note: wrong note type: bad value

and it would have taken a while to find --disable-stripping.

sean