[Libav-user] RTMP Play file descriptor leak

[wm4]

On Wed, 10 Sep 2014 12:37:19 +1100
Alexander Drozdov <adrozdoff at gmail.com> wrote:

> Hi!
> 
> In our project we uses FFmpeg to demux RTMP streams. Input stream takes
> from Wowza/nginx-rtmp. Our application is a daemon that try to connect to
> source periodicaly if it does not present (does not published to Wowza, for
> example). We also use interrupt callback to break connection if timeout is
> occured. So in this situation:
> - Alive server
> - Alive streaming application
> - Configured inerrupt callback with timeout
> - Disalive stream
> 
> TCP socket to server does not closes.
> 
> I look into code with debugger and found place where error is occured:
> rtmpproto.c, rtmp_open() L:2672
> 
> Root couse: return from function without resources clean up
> 
> Solution: replace return with 'goto fail'
> 
> Path is attached.
> 

Not many developers read this list, so maybe you should post it to
ffmpeg-devel. Your patch look ok; maybe using git format-patch would be
slightly better.