[Libav-user] AVFilter modify parameters

[Ronak]

Hi Paul,

Before I send you the changes, I'm noticing some crackling in the audio while I modify the gain on any one frequency band during playback.

I am assuming this has to do with the changes I made, and possibly a race condition or something similar.

I'm wondering if you would have any ideas why something like this would happen. 

I'm attaching the file where I made changes (the af_biquads.c file). Would you be able to point me to what could possibly cause this?

Ronak


-------------- next part --------------
A non-text attachment was scrubbed...
Name: af_biquads.c
Type: application/octet-stream
Size: 33029 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/libav-user/attachments/20171206/e0f75b26/attachment.obj>
-------------- next part --------------



> On Dec 3, 2017, at 12:31 PM, Ronak <ronak2121-at-yahoo.com at ffmpeg.org> wrote:
> 
> Thanks Paul. I was able to modify the af_biquads.c file to process commands and modify the equalization at runtime.
> 
> I would like to send you the changes so they can be included inside of ffmpeg. Would you be open to that?
> 
> 
>> On Dec 2, 2017, at 4:24 AM, Paul B Mahol <onemda at gmail.com> wrote:
>> 
>> On 12/2/17, Ronak <ronak2121-at-yahoo.com at ffmpeg.org> wrote:
>>> Are you saying that the treble, bass and equalizer filters will let me
>>> modify the gain at runtime?
>> 
>> No, i never said that.
>> 
>>> 
>>> What command would I send? I can't find any documentation that tells me what
>>> command to even send.
>>> 
>>> avfilter_graph_queue_command(self.filterGraph, band.name.UTF8String,
>>> "setGain??", "gain=6", NULL, 0)
>> 
>> Look at documentation for anequalizer or firequalizer filter.
>> 
>>> 
>>> 
>>>> On Dec 1, 2017, at 4:54 PM, Paul B Mahol <onemda at gmail.com> wrote:
>>>> 
>>>> On 12/1/17, Ronak <ronak2121-at-yahoo.com at ffmpeg.org
>>>> <mailto:ronak2121-at-yahoo.com at ffmpeg.org>> wrote:
>>>>> Out of curiosity, is there a reason why the Filters could not be mutable,
>>>>> so
>>>>> we can set the gain values dynamically?
>>>>> 
>>>>> Making them immutable makes it that much harder to integrate the
>>>>> library.
>>>> 
>>>> As already expained to you, there are filters that supports runtime
>>>> change of parameters.
>>>> 
>>>>> 
>>>>> 
>>>>>> On Nov 26, 2017, at 2:37 PM, Paul B Mahol <onemda at gmail.com> wrote:
>>>>>> 
>>>>>> On 11/26/17, Ronak <ronak2121-at-yahoo.com at ffmpeg.org> wrote:
>>>>>>> I see. I'm using the treble, bass and equalizer filters. And the user
>>>>>>> should
>>>>>>> have the ability to manipulate the gain at run time...
>>>>>>> 
>>>>>>> So, is the best thing to do to destroy and recreate the AVFilterGraph
>>>>>>> then?
>>>>>> 
>>>>>> Yes.
>>>>>> _______________________________________________
>>>>>> Libav-user mailing list
>>>>>> Libav-user at ffmpeg.org
>>>>>> http://ffmpeg.org/mailman/listinfo/libav-user
>>>>> 
>>>>> _______________________________________________
>>>>> Libav-user mailing list
>>>>> Libav-user at ffmpeg.org <mailto:Libav-user at ffmpeg.org>
>>>>> http://ffmpeg.org/mailman/listinfo/libav-user
>>>>> <http://ffmpeg.org/mailman/listinfo/libav-user>
>>>>> 
>>>> _______________________________________________
>>>> Libav-user mailing list
>>>> Libav-user at ffmpeg.org <mailto:Libav-user at ffmpeg.org>
>>>> http://ffmpeg.org/mailman/listinfo/libav-user
>>>> <http://ffmpeg.org/mailman/listinfo/libav-user>
>>> 
>> _______________________________________________
>> Libav-user mailing list
>> Libav-user at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/libav-user
> 
> _______________________________________________
> Libav-user mailing list
> Libav-user at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/libav-user