[FFmpeg-cvslog] r11883 - trunk/libavcodec/vorbis.c

[Balatoni Denes]

Hi!

One more thing...

Sunday 10 February 2008 20:21-kor Balatoni Denes ezt ?rta:
> Sunday 10 February 2008 18:23-kor Loren Merritt ezt ?rta:
> > Except
> > that a branch in an inner loop isn't the right fix, instead just allocate
> > a big enough buffer for floor1 that it fits.
>
> As Michael always says: patch welcome.

Actually I don't think it's a good idea (it is complicated managing different 
size buffers, etc.). Rather "while(++x < x1)" should be changed to the 
equivalent of "while (++x < FFMIN(x1, n))". If gcc can move the ffmin outside 
of the inner loop, than this is also fast (and if gcc can't move it than it 
can be moved by hand).

bye
Denes