[FFmpeg-cvslog] r14168 - trunk/libavformat/psxstr.c

Måns Rullgård mans
Fri Jul 11 20:51:45 CEST 2008


Michael Niedermayer <michaelni at gmx.at> writes:

> On Fri, Jul 11, 2008 at 06:37:00PM +0100, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
>> 
>> > On Fri, Jul 11, 2008 at 04:41:44PM +0100, M?ns Rullg?rd wrote:
>> >> 
>> >> michael wrote:
>> >> > Author: michael
>> >> > Date: Fri Jul 11 17:12:44 2008
>> >> > New Revision: 14168
>> >> >
>> >> > Log:
>> >> > simplify
>> >> 
>> >> Just as I was thinking the previous commit message was bad...
>> >
>> > I do not really mind that one, it is not (supposed to be) a functional
>> > change, so what "important" information is missing here? The affected
>> > file might not have hurt, but is seems a minor thing to me.
>> 
>> Yes, there is not supposed to be any functional change.  However, bugs
>> happen, and if I'm trying to figure out why something broke, it's nice
>> to be able to easily tell which commits might be relevant.  If the
>> commit message mentions psxstr, I know I can safely ignore it when
>> debugging some other format, for instance.  Seeing only "simplify", I
>> have to look at the diff to determine the irrelevance of this change.
>> 
>
>> I'm tempted to add a hook enforcing at least three words in a commit
>> message.  It is simply not possible to be accurate enough in only one
>> or two words.
>
> reindent, fixing typo and simplify are clear unless they are misused but
> i dont remember them being misused ...

There could still be a mistake in the commit, causing a bug.  I'm sure
it has happened at least once.

> I dont need a asshat hook that requires me to write "simplified some code"
> that does not help anyone.

Why do I get the impression you are being deliberately awkward just
for the sake of it?  This is just like with your English.  You knowing
what you simplified on the 11th July 2008, doesn't imply that
everybody else shares that knowledge.

> The part which is changed should be mentioned only when its not obvious
> from the file changed.
>
> for git, git-log --stat will show you which files changed with the messages.

Not on a single line, and that's when it becomes most useful.
Besides, a change to files like utils.c or dsputils.c might be
affecting only one or two codecs, and in those cases it's nice
to know this.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-cvslog mailing list