[FFmpeg-devel] [PATCH] Document opt.h:av_set_string functions

Stefano Sabatini stefano.sabatini-lala
Mon Jul 21 23:31:02 CEST 2008

On date Monday 2008-07-21 06:41:09 -0400, The Wanderer encoded:
> Diego Biurrun wrote:
> > On Fri, Jul 18, 2008 at 12:43:04AM +0200, Stefano Sabatini wrote:
> >> + * @param[in] val The value to set. If the field is not of a string
> >> + * type, then the given string is parsed.
> >> + * SI postfixes and some named scalars are supported.
> >> + * If the field is of a numeric type, it has to be a numeric or named
> >> + * scalar, behavior with more than one scalar and +- infix operators
> >> + * is undefined.
> > 
> > If in doubt, use a period instead of a comma.
> Here (for the second comma in the final sentence), a semicolon would
> work just as well.

Fixed with a period.

> >> + * If the field is of a flags type, it has to be a sequence of numeric
> >> + * scalars or named flags separated by '+' or '-'. Prefixing a flag
> >> + * with '+' causes it to be set without affecting the other flags,
> >> + * similarly '-' unsets a flag.
> > 
> > Similarly?

stefano at geppetto ~> dict similarly
1 definition found

>From The Collaborative International Dictionary of English v.0.48 [gcide]:

  Similarly \Sim"i*lar*ly\, adv.
     In a similar manner.
     [1913 Webster]

> I understood what it meant; "In a similar way, prefixing a flag with '-'
> causes it to be unset without affecting the other flags". The less
> verbose form is understandable and less clunky IMO. This should,
> however, be a separate 'sentence', split off by either a period or a
> semicolon.

Fixed with a semicolon.

PS Diego, I can't figure out what you mean with <complaint
type="standard">, the list of complaints I received in the many
documentation patches I strived to get applied is very looooooooong,
so to understand which is the one that I brake is not a simple deed,
furthermore I'm getting less and less motivated into providing this
kind of patches, so please be more explicit and I'll try to fix it the
next time.

FFmpeg = Funny and Foolish Minimal Portable Ecumenical Game
-------------- next part --------------
A non-text attachment was scrubbed...
Name: document-av-set-string-03.patch
Type: text/x-diff
Size: 1524 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080721/cdcf74c8/attachment.patch>

More information about the ffmpeg-devel mailing list