[FFmpeg-devel] [PATCH] split-radix FFT

Michael Niedermayer michaelni
Tue Jul 29 22:21:19 CEST 2008

On Tue, Jul 29, 2008 at 10:36:01PM +0300, Uoti Urpala wrote:
> On Tue, 2008-07-29 at 20:42 +0200, Michael Niedermayer wrote:
> > Iam not strongly opposed to a patch that adds them one by one to the
> > exported globals or cleanly splits header files into internal & external
> > where this is not done yet and sets visibility per file.
> > But i wont do it myself, id just review the patch!

Note i do prefer if its done filewise where possible, public API and non
public functions really shouldnt be in the same headers anyway ...

> Most of the changes should not be particularly hard. One question is the
> syntax (macro names?) actually used for the declarations. I don't have
> any particularly strong opinion about that at the moment.
> > Also such a patch would not allow us to remove all the MANGLE() they still
> > would be needed for forcing textrels on x86-32 and for old gcc versions.
> Does using -fPIC but still forcing some textrels with MANGLE give some
> real benefit over say compiling i386/ without -fPIC (which probably
> wouldn't be too hard to set up)?

gcc 2.95 and some of the 3. versions are limited to 9 arguments per asm
and will silently miscomile code if this is exceeded. and "+r" counts as 2.
Removing MANGLE means more arguments for the asm() and iam pretty sure
many will break with old gcc.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080729/6b972658/attachment.pgp>

More information about the ffmpeg-devel mailing list