[FFmpeg-devel] [PATCH] Treat FLV packets with AVCPacketType zero as extradata

Michael Niedermayer michaelni at gmx.at
Fri Aug 23 00:17:22 CEST 2013

On Thu, Aug 22, 2013 at 05:06:36PM +0900, Amarghosh Vadakkoot wrote:
> When type zero avc packets are returned as normal video packets, the caller
> attempts to parse them as NAL unit and fails.

what the caller does, depends on the caller, ffmpeg doesnt fail it
doest even try to parse them rather it passes them to libavcodec
which then parses them and does not fail either.

> If they are treated as
> extra_data and returned in the side_data of next packet, the caller can
> easily differentiate between avcC data and NAL units.

yes but whatever it can, it does not work, your patch simply breaks
Iam sure you will agree that we cannot apply a patch that breaks
things and that this breakage has to be corrected before the patch
can be applied

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130823/b0305dc1/attachment.asc>

More information about the ffmpeg-devel mailing list