[FFmpeg-devel] [PATCH] Treat FLV packets with AVCPacketType zero as extradata

Amarghosh Vadakkoot amarghosh at google.com
Fri Aug 23 03:14:34 CEST 2013

Agreed. I will adopt the same heuristic method to identify avcC data. If
that doesn't work, I will try to come up with a non-breaking solution.

On Fri, Aug 23, 2013 at 7:17 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Thu, Aug 22, 2013 at 05:06:36PM +0900, Amarghosh Vadakkoot wrote:
> > When type zero avc packets are returned as normal video packets, the
> caller
> > attempts to parse them as NAL unit and fails.
> what the caller does, depends on the caller, ffmpeg doesnt fail it
> doest even try to parse them rather it passes them to libavcodec
> which then parses them and does not fail either.
> > If they are treated as
> > extra_data and returned in the side_data of next packet, the caller can
> > easily differentiate between avcC data and NAL units.
> yes but whatever it can, it does not work, your patch simply breaks
> ffmpeg.
> Iam sure you will agree that we cannot apply a patch that breaks
> things and that this breakage has to be corrected before the patch
> can be applied
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> No snowflake in an avalanche ever feels responsible. -- Voltaire
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Thanks and regards,
Amarghosh Vadakkoot

More information about the ffmpeg-devel mailing list